Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust-bip39 and simplify fn Mnemonic::new #227

Closed
wants to merge 1 commit into from
Closed

Update rust-bip39 and simplify fn Mnemonic::new #227

wants to merge 1 commit into from

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 9, 2022 •
edited
Loading

Description

Fixes #226

Notes to the reviewers

This is still a WIP.

Changelog notice

Fix Mnemonic::new to work with 15 and 21 word counts.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Nov 9, 2022
@notmandatory notmandatory added the bug Something isn't working label Nov 9, 2022
@notmandatory
Copy link
Member Author

notmandatory commented Nov 9, 2022 •
edited
Loading

Need to figure out if it makes sense to enable the bip39 rand feature in bdk or to only enable it in this lib.

@notmandatory notmandatory force-pushed the update_rust-bip39 branch 2 times, most recently from 3e0fb35 to f711139 Compare November 9, 2022 23:06
@notmandatory
Copy link
Member Author

This is resolved by bitcoindevkit/bdk#875.

@thunderbiscuit
Copy link
Member

Sweeeeeet.

@thunderbiscuit thunderbiscuit mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit Awaiting requested review from thunderbiscuit

Assignees

@notmandatory notmandatory

Labels
bug Something isn't working
Projects
BDK-Bindings
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Currently rust-bip39 only supports bip39 word counts divisible by 6
2 participants
@notmandatory @thunderbiscuit